Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improving error handling when Docker daemon is not running #7

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 30, 2023

About

GH-5 did not quite make it for @horta, see #4 (comment). While it works well on my machine, this patch tries to improve the situation in cases I can't reproduce.

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -1.34% ⚠️

Comparison is base (95c52b7) 96.40% compared to head (e2d2b55) 95.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   96.40%   95.07%   -1.34%     
==========================================
  Files           5        5              
  Lines         139      142       +3     
==========================================
+ Hits          134      135       +1     
- Misses          5        7       +2     
Flag Coverage Δ
unittests 95.07% <60.00%> (-1.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pytest_mqtt/mosquitto.py 82.92% <60.00%> (-3.92%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review July 30, 2023 14:53
@amotl amotl merged commit 1757586 into main Aug 3, 2023
6 of 8 checks passed
@amotl amotl deleted the improve-docker-down branch August 3, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant