-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error message when docker daemon is not running is too long to understand #4
Comments
Dear Danilo, thanks for the report. GH-5 may have a fix that helps already. Let me know if you think that will fit your needs. With kind regards, |
Hi again. pytest-mqtt 0.3.0 has been released, including the improvement referenced above. |
Thanks a lot! Nearly there. Look:
The call Minimum example:
|
Oh my. It looks like it was too late at night for doing this properly. Will try to revisit later. Thanks! |
Dear Danilo, let's try again with the changes from GH-7. May I ask you to verify it will work better now by temporarily installing directly from this branch? pip install --upgrade 'git+https://github.com/mqtt-tools/pytest-mqtt@improve-docker-down' With kind regards, |
The error has improved =) It now says "ConnectionError: Cannot connect to the Docker daemon. Is the docker daemon running?" I'm satisfied =)
|
Excellent, thanks. While I also agree that this kind of stacktrace is way too much, I do not want to prematurely hide anything which could help others in edge case situations, when connectivity may be broken by not so obvious reasons. Do you agree, or do you have different suggestions whether/how to improve on this detail? |
I agree. The noise doesn't seem to do with your package... |
All right, so be it. Version 0.3.1 has been released, including that fix. Thanks for your support! |
Hi Danilo, we guess it will be fine to close this issue. Please let us know if you are still observing any issues, or if you think your report has not been handled well enough. Thanks! With kind regards, |
First of all, thank your for this package!
I'm running tests on a mac m1 machine. If I forget to start Docker and try to test using
mosquitto
fixture I get the following very long error:It would be nice to have a simple exception message telling the developer to make sure Docker is running.
The text was updated successfully, but these errors were encountered: