Fixes for apple-clang crashes and performance issues #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source of the crash with the latest changes seemed to be from the `IsOfCharacter` concept. This concept was refactored to use some type traits and more simple concepts although with less strict requirements. A new macro, `MP_UNITS_APPLE_CLANG_HACKS` was added to mp-units/bits/hacks.h to enable work arounds for pre-Xcode 16.1 apple-clang. Some tests were not passing and were removed with the preprocessor macro for apple-clang hacks is defined. Adding `ComplexFunctionsAvailable` and `VectorFunctionsAvailable` fixed some test failures in concepts_test.cpp but not all.
mpusz
requested changes
Dec 9, 2024
rothmichaels
force-pushed
the
bugfix/apple-clang-crash
branch
from
fa9e052 to
d30f5a6
Compare
Co-authored-by: Mateusz Pusz <[email protected]>
Co-authored-by: Mateusz Pusz <[email protected]>
|
@mpusz I guess all we needed to do was remove |
mpusz
reviewed
Dec 19, 2024
Removing the `WeaklyRegular` requirement from the `Scalar`, `Complex`, and `Vector` concepts seems to address compiler crashes or long compilation times with apple-clang included in Xcode 15. I thought I had previously tried removing the `WeaklyRegular` requirement and it had not solved the problem but either I made a mistake with this test or some other changes after rebasing this work changed the situation.
rothmichaels
force-pushed
the
bugfix/apple-clang-crash
branch
from
d79c178 to
ada508a
Compare
Co-authored-by: Mateusz Pusz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source of the crash with the latest changes seemed to be from the
IsOfCharacterconcept. This concept was refactored to use some type traits and more simple concepts although with less strict requirements.A new macro,
MP_UNITS_APPLE_CLANG_HACKSwas added to mp-units/bits/hacks.h to enable work arounds for pre-Xcode 16.1 apple-clang.Some tests were not passing and were removed with the preprocessor macro for apple-clang hacks is defined.
Adding
ComplexFunctionsAvailableandVectorFunctionsAvailablefixed some test failures in concepts_test.cpp but not all.