Fix for slow compilation with apple-clang #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of the `Representation` concept using `detail::ScalarRepresentation`, `detail::ComplexRepresentation`, `detail::VectorRepresentation`, `detail::TensorRepresentation` was causing some translation units to take two orders of magnitude longer to compile. This was observed with Xcode 15.1 and 15.4. As a workaround use the old implementation of `Representation` when building with apple-clang. The new implementation should be tested with Xcode 16 to see if this workaround needs to be applied to all shipping versions of apple-clang or <16. More investigation could be done to try to allow the new constrained behavior in a more efficient way now that we have isolated the issue.
|
Formatting CI failed. Please check https://mpusz.github.io/mp-units/latest/getting_started/contributing/#unified-code-formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of the
Representationconcept usingdetail::ScalarRepresentation,detail::ComplexRepresentation,detail::VectorRepresentation,detail::TensorRepresentationwas causing some translation units to take two orders of magnitude longer to compile. This was observed with Xcode 15.1 and 15.4.As a workaround use the old implementation of
Representationwhen building with apple-clang.The new implementation should be tested with Xcode 16 to see if this workaround needs to be applied to all shipping versions of apple-clang or <16.
More investigation could be done to try to allow the new constrained behavior in a more efficient way now that we have isolated the issue.