Commits on Jan 4, 2018

1. Bug 1428051 - Remove unused Angular DI parameters …

   Found by adjusting the eslint `no-unused-vars` rule, changing the
   `args` preference from `after-used` to `all`:
   https://eslint.org/docs/rules/no-unused-vars.html#options
   
   That rule is too noisy to enable by default. Ideally we could use the
   AngularJS eslint plugin/config (which has specific rules for this),
   but it's not compatible with latest eslint:
   EmmanuelDemey/eslint-plugin-angular#490
   
   Unless these DI parameters can have side-effects I'm not aware of,
   this change should be reasonably safe, since eslint's `no-undef` rule
   will error if anything was removed that was being directly referenced.

   

   edmorley committed Jan 4, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for cfd8d57
   • Browse repository at this point

   Copy the full SHA

   cfd8d57 View commit details

   Browse the repository at this point in the history