Bug 1428051 - Remove unused Angular DI parameters #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by adjusting the eslint `no-unused-vars` rule, changing the `args` preference from `after-used` to `all`: https://eslint.org/docs/rules/no-unused-vars.html#options That rule is too noisy to enable by default. Ideally we could use the AngularJS eslint plugin/config (which has specific rules for this), but it's not compatible with latest eslint: EmmanuelDemey/eslint-plugin-angular#490 Unless these DI parameters can have side-effects I'm not aware of, this change should be reasonably safe, since eslint's `no-undef` rule will error if anything was removed that was being directly referenced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by adjusting the eslint
no-unused-varsrule, changing theargspreference fromafter-usedtoall:https://eslint.org/docs/rules/no-unused-vars.html#options
That rule is too noisy to enable by default. Ideally we could use the AngularJS eslint plugin/config (which has specific rules for this), but it's not compatible with latest eslint:
EmmanuelDemey/eslint-plugin-angular#490
Unless these DI parameters can have side-effects I'm not aware of, this change should be reasonably safe, since eslint's
no-undefrule will error if anything was removed that was being directly referenced.