Add more options to the filtering menus, and add a "no value" filter for the confidence column

src/__tests__/CompareResults/ResultsTable.test.tsx

@@ -123,7 +123,7 @@ describe('Results Table', () => {
       '  - OSX, Improvement, Low',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
       '  - Android, Improvement, Low',
     ]);
 
@@ -150,13 +150,13 @@ describe('Results Table', () => {
       '  - Android, Improvement, Low',
     ]);
 
-    await clickMenuItem(user, /Platform/, 'Clear filters');
+    await clickMenuItem(user, /Platform/, 'Select all values');
     expect(summarizeVisibleRows()).toEqual([
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
       '  - OSX, Improvement, Low',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
       '  - Android, Improvement, Low',
     ]);
 
@@ -165,7 +165,7 @@ describe('Results Table', () => {
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
       '  - Android, Improvement, Low',
     ]);
 
@@ -174,7 +174,13 @@ describe('Results Table', () => {
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
+    ]);
+
+    await clickMenuItem(user, /Platform/, /Select only.*Android/);
+    expect(summarizeVisibleRows()).toEqual([
+      'a11yr dhtml.html spam opt e10s fission stylo webrender',
+      '  - Android, Improvement, Low',
     ]);
   });
 
@@ -188,7 +194,7 @@ describe('Results Table', () => {
       '  - OSX, Improvement, Low',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
     ]);
 
     const user = userEvent.setup({ delay: null });
@@ -199,19 +205,26 @@ describe('Results Table', () => {
       '  - Linux, Regression, Medium',
     ]);
 
-    await clickMenuItem(user, /Status/, /Clear filters/);
+    await clickMenuItem(user, /Status/, /Select all values/);
     await clickMenuItem(user, /Status/, /Improvement/);
     expect(summarizeVisibleRows()).toEqual([
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
     ]);
+
     await clickMenuItem(user, /Status/, /Regression/);
     expect(summarizeVisibleRows()).toEqual([
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
+    ]);
+
+    await clickMenuItem(user, /Status/, /Select only.*Regression/);
+    expect(summarizeVisibleRows()).toEqual([
+      'a11yr dhtml.html spam opt e10s fission stylo webrender',
+      '  - Linux, Regression, Medium',
     ]);
   });
 
@@ -225,7 +238,7 @@ describe('Results Table', () => {
       '  - OSX, Improvement, Low',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
     ]);
 
     const user = userEvent.setup({ delay: null });
@@ -234,29 +247,43 @@ describe('Results Table', () => {
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
     ]);
 
     await clickMenuItem(user, /Confidence/, /High/);
     expect(summarizeVisibleRows()).toEqual([
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
       '  - Linux, Regression, Medium',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
     ]);
 
     await clickMenuItem(user, /Confidence/, /Medium/);
     expect(summarizeVisibleRows()).toEqual([
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
     ]);
 
-    await clickMenuItem(user, /Confidence/, /Clear filters/);
+    await clickMenuItem(user, /Confidence/, /Select all values/);
     expect(summarizeVisibleRows()).toEqual([
       'a11yr dhtml.html spam opt e10s fission stylo webrender',
       '  - OSX, Improvement, Low',
       '  - Linux, Regression, Medium',
       '  - Windows, -, High',
-      '  - Windows, -, ',
+      '  - Windows, -, -',
+    ]);
+
+    await clickMenuItem(user, /Confidence/, /No value/);
+    expect(summarizeVisibleRows()).toEqual([
+      'a11yr dhtml.html spam opt e10s fission stylo webrender',
+      '  - OSX, Improvement, Low',
+      '  - Linux, Regression, Medium',
+      '  - Windows, -, High',
+    ]);
+
+    await clickMenuItem(user, /Confidence/, /Select only.*High/);
+    expect(summarizeVisibleRows()).toEqual([
+      'a11yr dhtml.html spam opt e10s fission stylo webrender',
+      '  - Windows, -, High',
     ]);
   });
 });

src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap

@@ -1200,7 +1200,9 @@ exports[`Results View The table should match snapshot and other elements should
                 <div
                   class="confidence cell"
                   role="cell"
-                />
+                >
+                  -
+                </div>
                 <div
                   class="total-runs cell"
                   role="cell"

src/__tests__/CompareResults/__snapshots__/ResultsTable.test.tsx.snap

@@ -1973,7 +1973,9 @@ exports[`Results Table Should match snapshot 1`] = `
                             <div
                               class="confidence cell"
                               role="cell"
-                            />
+                            >
+                              -
+                            </div>
                             <div
                               class="total-runs cell"
                               role="cell"

src/__tests__/CompareResults/__snapshots__/ResultsView.test.tsx.snap

@@ -1863,7 +1863,9 @@ exports[`Results View The table should match snapshot and other elements should
                 <div
                   class="confidence cell"
                   role="cell"
-                />
+                >
+                  -
+                </div>
                 <div
                   class="total-runs cell"
                   role="cell"

src/components/CompareResults/ResultsTable.tsx

@@ -74,9 +74,15 @@ const cellsConfiguration: CompareResultsTableConfig[] = [
     filter: true,
     key: 'confidence',
     gridWidth: '1fr',
-    possibleValues: ['Low', 'Medium', 'High'],
-    matchesFunction: (result: CompareResultsItem, value: string) =>
-      result.confidence_text === value,
+    possibleValues: ['No value', 'Low', 'Medium', 'High'],
+    matchesFunction: (result: CompareResultsItem, value: string) => {
+      switch (value) {
+        case 'No value':
+          return !result.confidence_text;
+        default:
+          return result.confidence_text === value;
+      }
+    },
   },
   {
     name: 'Total Runs',

src/components/CompareResults/RevisionRow.tsx

@@ -396,7 +396,7 @@ function RevisionRow(props: RevisionRowProps) {
         </div>
         <div className='confidence cell' role='cell'>
           {confidenceText && confidenceIcons[confidenceText]}
-          {confidenceText}
+          {confidenceText || '-'}
         </div>
         <div className='total-runs cell' role='cell'>
           <span>

src/components/CompareResults/TableHeader.tsx

@@ -1,6 +1,7 @@
 import CheckIcon from '@mui/icons-material/Check';
 import FilterListIcon from '@mui/icons-material/FilterList';
 import Button from '@mui/material/Button';
+import Divider from '@mui/material/Divider';
 import Menu from '@mui/material/Menu';
 import MenuItem from '@mui/material/MenuItem';
 import {
@@ -43,6 +44,13 @@ function FilterableColumn({
     onToggle(newUncheckedValues);
   };
 
+  const onClickOnlyFilter = (value: string) => {
+    const newUncheckedValues = new Set(
+      possibleValues.filter((possibleValue) => possibleValue !== value),
+    );
+    onToggle(newUncheckedValues);
+  };
+
   const hasFilteredValues = uncheckedValues && uncheckedValues.size;
   const buttonAriaLabel = hasFilteredValues
     ? `${name} (Click to filter values. Some filters are active.)`
@@ -75,8 +83,19 @@ function FilterableColumn({
       </Button>
       <Menu {...bindMenu(popupState)}>
         <MenuItem dense={true} onClick={onClear}>
-          Clear filters
+          Select all values
         </MenuItem>
+        <Divider />
+        {possibleValues.map((possibleValue) => (
+          <MenuItem
+            dense={true}
+            key={possibleValue}
+            onClick={() => onClickOnlyFilter(possibleValue)}
+          >
+            Select only “{possibleValue}”
+          </MenuItem>
+        ))}
+        <Divider />
         {possibleValues.map((possibleValue) => {
           const isChecked =
             !uncheckedValues || !uncheckedValues.has(possibleValue);

src/types/state.ts

@@ -108,7 +108,7 @@ export type CompareResultsItem = {
   is_regression: boolean;
   is_meaningful: boolean;
   more_runs_are_needed: boolean;
-  /* 
+  /*
   Each test has a signature and each signature may or may not have a parent_signature.
   If a signature has a parent_signature then we are looking at a subtest. For regular tests this field will be null.
   */

src/types/types.ts

@@ -19,7 +19,7 @@ export type CompareResultsTableConfig =
       matchesFunction: (result: CompareResultsItem, value: string) => boolean;
     };
 
-export type ConfidenceText = 'High' | 'Medium' | 'Low';
+export type ConfidenceText = 'High' | 'Medium' | 'Low' | '';
 
 export type MeasurementUnit =
   | 'W'