Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options to the filtering menus, and add a "no value" filter for the confidence column #793

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

julienw
Copy link
Contributor

@julienw julienw commented Oct 23, 2024

This PR does a few things:
Commit 1 adds a "no value" filter for the confidence column. It was driving me crazy.
Commit 2 adds a few options to all filtering menus: it adds an entry "show only XXX" for every possible values. I find it might be easier to use for our users.

=> Deploy preview <=

image

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for mozilla-perfcompare ready!

Name Link
🔨 Latest commit 1a1c4b1
🔍 Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/6718f48508b2520008eb90a7
😎 Deploy Preview https://deploy-preview-793--mozilla-perfcompare.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@esanuandra
Copy link
Collaborator

I'm not sure if only changing the icon color of the column is enough to suggest these results are filtered.

@julienw
Copy link
Contributor Author

julienw commented Nov 6, 2024

I'm not sure if only changing the icon color of the column is enough to suggest these results are filtered.

Yeah, Dasha suggested another design (basically showing the number of checked filters) but I never got to it. If that's not done yet, I'll file another JIRA ticket about that with the screenshots so that we don't lose them (they're on slack currently).
But the color was there before already, this was in my first impelmentation, so I don't really want to change that in this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants