-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize callbacks interfaces (250) #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we're removing callback parameters that cost 100s of gas passing while it can greatly improve some (but not all, perhaps not even the majority of) integrators' lives... I really don't get where we're going
Closing as Rubilmax, still one of the biggest Blue's integrator, is against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code works, but I didn't change my mind:
we're removing callback parameters that cost 100s of gas passing while it can greatly improve some (but not all, perhaps not even the majority of) integrators' lives
EDIT: it's not a big deal
Attempt to fix #245, with the following rationale: