Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize callbacks interfaces (260) #260

Closed
wants to merge 1 commit into from
Closed

Harmonize callbacks interfaces (260) #260

wants to merge 1 commit into from

Conversation

MathisGD
Copy link
Contributor

Fixes #245

@MathisGD MathisGD self-assigned this Aug 10, 2023
@MathisGD MathisGD requested review from Rubilmax, pakim249CAL, a team, MerlinEgalite, Jean-Grimal and makcandrov and removed request for a team August 10, 2023 12:13
@MathisGD MathisGD marked this pull request as ready for review August 10, 2023 12:49
@MathisGD MathisGD requested review from QGarchery and peyha and removed request for a team August 10, 2023 12:49
@MathisGD MathisGD mentioned this pull request Aug 10, 2023
Closed
@MathisGD MathisGD changed the title Harmonize callbacks interfaces Harmonize callbacks interfaces (260) Aug 10, 2023
@MathisGD
Copy link
Contributor Author

Closing in favor of #250

@MathisGD MathisGD closed this Aug 11, 2023
@MerlinEgalite MerlinEgalite deleted the refactor/callbacks-interface-1 branch August 18, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakim249CAL pakim249CAL pakim249CAL left review comments

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@MerlinEgalite MerlinEgalite Awaiting requested review from MerlinEgalite MerlinEgalite was automatically assigned from morpho-labs/onchain

@makcandrov makcandrov Awaiting requested review from makcandrov makcandrov was automatically assigned from morpho-labs/onchain

@QGarchery QGarchery Awaiting requested review from QGarchery QGarchery was automatically assigned from morpho-labs/protocol

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-labs/protocol

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we pass the token address to the callback functions ?
6 participants
@MathisGD @Rubilmax @MerlinEgalite @pakim249CAL @Jean-Grimal @makcandrov