Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eth outbound queue and system pallets #742

Merged
merged 43 commits into from
Nov 26, 2024

Conversation

tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Nov 5, 2024

Adds these pallets to Dancelight runtime:

        EthereumOutboundQueue: snowbridge_pallet_outbound_queue = 101,
        EthereumSystem: snowbridge_pallet_system = 103,

Requires some changes in polkadot-sdk, already merged in our stable2407 branch but not in polkadot upstream

@tmpolaczyk tmpolaczyk changed the title Tomasz generic aggregate message origin [WIP] Add eth outbound queue and system pallets Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1424 KB (no changes) ✅

flashbox runtime: 820 KB (no changes) ✅

dancelight runtime: 2072 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Coverage Report

(master)

@@                             Coverage Diff                             @@
##           master   tomasz-generic-aggregate-message-origin      +/-   ##
===========================================================================
- Coverage   65.01%                                    64.57%   -0.44%     
+ Files         312                                       317       +5     
+ Lines       54978                                     55357     +379     
===========================================================================
+ Hits        35741                                     35745       +4     
+ Misses      19237                                     19612     +375     
Files Changed Coverage
/pallets/external-validator-slashes/src/lib.rs 74.71% (-10.25%)
/solo-chains/runtime/dancelight/src/lib.rs 66.19% (-0.88%)

Coverage generated Tue Nov 26 12:14:28 UTC 2024

@tmpolaczyk tmpolaczyk changed the title [WIP] Add eth outbound queue and system pallets Add eth outbound queue and system pallets Nov 8, 2024
@tmpolaczyk tmpolaczyk marked this pull request as ready for review November 8, 2024 10:22
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval is implicit, but I refuse to tick the green button until we have benchmarked the instructions, just in case we miss them. But the pr looks good

@girazoki
Copy link
Collaborator

also, add a description

@girazoki girazoki mentioned this pull request Nov 19, 2024
1 task
@tmpolaczyk tmpolaczyk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Nov 20, 2024
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @tmpolaczyk

primitives/bridge/src/lib.rs Outdated Show resolved Hide resolved
primitives/bridge/src/lib.rs Outdated Show resolved Hide resolved
solo-chains/runtime/dancelight/src/lib.rs Show resolved Hide resolved
Copy link
Contributor

@ParthDesai ParthDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Only remaining part would be to define command and review the overall flow but that can be handled in next PR.

@tmpolaczyk tmpolaczyk merged commit b866a6e into master Nov 26, 2024
42 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-generic-aggregate-message-origin branch November 26, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants