-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eth outbound queue and system pallets #742
Conversation
WASM runtime size check:Compared to target branchdancebox runtime: 1424 KB (no changes) ✅ flashbox runtime: 820 KB (no changes) ✅ dancelight runtime: 2072 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
…egate-message-origin
Coverage Report@@ Coverage Diff @@
## master tomasz-generic-aggregate-message-origin +/- ##
===========================================================================
- Coverage 65.01% 64.57% -0.44%
+ Files 312 317 +5
+ Lines 54978 55357 +379
===========================================================================
+ Hits 35741 35745 +4
+ Misses 19237 19612 +375
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval is implicit, but I refuse to tick the green button until we have benchmarked the instructions, just in case we miss them. But the pr looks good
also, add a description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job @tmpolaczyk
…egate-message-origin
…egate-message-origin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Only remaining part would be to define command and review the overall flow but that can be handled in next PR.
Adds these pallets to Dancelight runtime:
Requires some changes in polkadot-sdk, already merged in our stable2407 branch but not in polkadot upstream