[WIP] Add inbound queue #750
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchdancebox runtime: 1412 KB (no changes) ✅ flashbox runtime: 832 KB (no changes) ✅ dancelight runtime: 2088 KB (no changes) ✅ container chain template simple runtime: 1088 KB (no changes) ✅ container chain template frontier runtime: 1388 KB (no changes) ✅ |
ParthDesai
force-pushed
the
add-inbound-queue
branch
from
529100a
to
77d47fb
Compare
girazoki
reviewed
Nov 19, 2024
solo-chains/runtime/dancelight/src/bridge_to_ethereum_config.rs
Outdated
Show resolved
Hide resolved
girazoki
reviewed
Nov 19, 2024
| /// indeed send a message intended for this processor. | ||
| pub const MAGIC_BYTES: [u8; 4] = [112, 21, 0, 56]; | ||
|
|
||
| #[derive(Encode, Decode)] |
There was a problem hiding this comment.
same, can we move to primitives?
girazoki
reviewed
Nov 19, 2024
solo-chains/runtime/dancelight/src/tests/inbound_queue_tests/mock.rs
Outdated
Show resolved
Hide resolved
Coverage Report@@ Coverage Diff @@
## tomasz-generic-aggregate-message-origin add-inbound-queue +/- ##
======================================================================================
- Coverage 65.34% 64.89% -0.45%
+ Files 310 318 +8
+ Lines 54174 54607 +433
======================================================================================
+ Hits 35395 35434 +39
+ Misses 18779 19173 +394
|
ParthDesai
force-pushed
the
add-inbound-queue
branch
from
aff8090
to
deba13c
Compare
ParthDesai
force-pushed
the
add-inbound-queue
branch
from
deba13c
to
1166efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds inbound queue to starlight and include tests for the same.
It adds message processor called
SymbioticMessageProcessorwhich upon receiving new validators, callsExternalValidatorspallet to set the validators.What is remaining?
Note
The base of the PR is at tomasz-generic-aggregate-message-origin since this PR is dependent upon code introduced there.