Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6348): Wrap thrown errors in JS Error objects with stacks #25

Merged
merged 4 commits into from
Aug 29, 2024
Merged

fix(NODE-6348): Wrap thrown errors in JS Error objects with stacks #25

merged 4 commits into from
Aug 29, 2024

Commits on Aug 27, 2024

  1. Wrap thrown errors in JS Error objects with stacks 

    We noticed in our usage of this package that thrown errors (eg: "Unknown frame descriptor") don't have a useful .stack property. This makes debugging harder. It seems this is expected behavior for errors created via napi at least on V8; it seems that the best way to remedy this is to recreate Error objects on the JS side?
    @sophiebits
    sophiebits committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c53e517 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Durran Jordan <[email protected]>
    @sophiebits @durran
    sophiebits and durran authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    16e0292 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. move bindings to a different file, shorten function names

    @sophiebits
    sophiebits committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    41ef5c2 View commit details
    Browse the repository at this point in the history

  2. refactor: use old index.js in bindings.js

    @durran
    durran committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    65fed03 View commit details
    Browse the repository at this point in the history