ready to merge: split Birt-Hogg-Dube syndrome #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrinatoro
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
@nicolevasilevsky Looks good. Only one comment (I don't think we need the "excludes from QC checks-single child" annotation anymore), otherwise it can be merged.
src/ontology/mondo-edit.obo
Outdated
| is_a: MONDO:0800444 {source="OMIM:135150"} ! Birt-Hogg-Dube syndrome | ||
| intersection_of: MONDO:0800444 ! Birt-Hogg-Dube syndrome | ||
| intersection_of: has_material_basis_in_germline_mutation_in http://identifiers.org/hgnc/27310 ! FLCN | ||
| relationship: excluded_from_qc_check http://purl.obolibrary.org/obo/mondo/sparql/qc/general/qc-single-child.sparql |
There was a problem hiding this comment.
This is probably not needed anymore?
sabrinatoro
requested changes
Nov 21, 2023
| property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/6518" xsd:anyURI | ||
| property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/6749" xsd:anyURI | ||
| property_value: IAO:0006012 "2023-10-01" xsd:string | ||
| is_obsolete: true | ||
| replaced_by: MONDO:0800444 |
There was a problem hiding this comment.
@nicolevasilevsky this should not be "replaced_by" should be "considered" with both new terms
|
@nicolevasilevsky Apologies, I just saw something to change |
nicolevasilevsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6518
close #6546
(the two tickets were related so I addressed them on one branch)