Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ready to merge: split bleeding diathesis due to thromboxane synthesis deficiency #6896

Merged
merged 2 commits into from
Nov 27, 2023
Merged

ready to merge: split bleeding diathesis due to thromboxane synthesis deficiency #6896

merged 2 commits into from
Nov 27, 2023

Conversation

nicolevasilevsky
Copy link
Member

@nicolevasilevsky nicolevasilevsky commented Nov 21, 2023 •
edited
Loading

close #6419

@nicolevasilevsky nicolevasilevsky added the split requests for term splits label Nov 21, 2023
@nicolevasilevsky nicolevasilevsky mentioned this pull request Nov 21, 2023
Closed
@sabrinatoro
Copy link
Collaborator

@nicolevasilevsky I think #6546 was supposed to be added to #6895 and not this PR.

@nicolevasilevsky
Copy link
Member Author

you are right! I will update this

@sabrinatoro
Copy link
Collaborator

sabrinatoro commented Nov 21, 2023 •
edited
Loading

UPDATE: ignore this

Maybe you meant: #6897

sabrinatoro
sabrinatoro requested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky
Only one change requested. Please see comment.

src/ontology/mondo-edit.obo
property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/6419#issuecomment-1615253065" xsd:anyURI
property_value: IAO:0006012 "2023-11-01" xsd:string
is_obsolete: true
replaced_by: MONDO:0800446
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "consider" with both new IDs (because this obsoleted term represents 2 different terms)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right, thanks for catching that

@nicolevasilevsky nicolevasilevsky changed the title split bleeding diathesis due to thromboxane synthesis deficiency ready to merge: split bleeding diathesis due to thromboxane synthesis deficiency Nov 21, 2023
@nicolevasilevsky nicolevasilevsky merged commit 865b634 into master Nov 27, 2023
1 check passed
@nicolevasilevsky nicolevasilevsky deleted the issue-6419 branch November 27, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrinatoro sabrinatoro sabrinatoro requested changes

@twhetzel twhetzel Awaiting requested review from twhetzel twhetzel is a code owner

Assignees

@nicolevasilevsky nicolevasilevsky

Labels
split requests for term splits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split 'bleeding diathesis due to thromboxane synthesis deficiency'
3 participants
@nicolevasilevsky @sabrinatoro @twhetzel