Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: ODK upgrade && odkrunner - build #731

Draft
wants to merge 1 commit into
base: odk-updates
Choose a base branch
from
Draft

DO NOT MERGE: ODK upgrade && odkrunner - build #731

wants to merge 1 commit into from

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 mentioned this pull request Dec 19, 2024
Open
9 tasks
@joeflack4 joeflack4 changed the title ODK upgrade && odkrunner DO NOT MERGE: ODK upgrade && odkrunner - build Dec 19, 2024
@joeflack4 joeflack4 marked this pull request as draft December 19, 2024 08:15
@joeflack4 joeflack4 self-assigned this Dec 19, 2024
@joeflack4 joeflack4 added the build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes label Dec 19, 2024
joeflack4
joeflack4 commented Dec 19, 2024
View reviewed changes
Copy link
Contributor Author

@joeflack4 joeflack4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Most important thing is that this ran smoothly without error.

joeflack4
joeflack4 commented Dec 19, 2024
View reviewed changes
src/ontology/reports/sync-synonym/synonym_sync_combined_cases.robot.tsv
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletion of this file expected in this build; Fixed by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twhetzel twhetzel Awaiting requested review from twhetzel

@matentzn matentzn Awaiting requested review from matentzn

Assignees

@joeflack4 joeflack4

Labels
build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joeflack4