ODK upgrade && odkrunner
#728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update: ODK 1.5.3 --> 1.5.4 - Update: Using odkrunner now instead of run.sh. Requires just a documentation update.
matentzn
approved these changes
Dec 19, 2024
README.md
Outdated
| @@ -14,6 +14,8 @@ Python is a dev dependency. It's not needed to run the docker containers, but ne | |||
| One or both of the following, depending on if you want to run the stable build `latest` or `dev`: | |||
| - a. `docker pull obolibrary/odkfull:latest` | |||
| - b. `docker pull obolibrary/odkfull:dev` | |||
| 4. Optional: [`odkrunner`](https://github.com/gouttegd/odkrunner): Alternative to `run.sh`. If using this, you would run | |||
| like `odkrun make build-mondo-ingest` instead of `sh run.sh make build-mondo-ingest`. | |||
There was a problem hiding this comment.
Why not simply odk, instead of odkrun, that's what I do.
There was a problem hiding this comment.
I was thinking that too when I first saw this.
Well, we can do that and update these docs to something like:
Suggestion: Rename the binary to
odk, and use likeodk make build-mondo-ingestinstead ofsh run.sh make build-mondo-ingest
There was a problem hiding this comment.
Oh, lol, I had a conflict with an existing odk on my machine: Open Data Kit
I was much more intimately involved with that ODK than Ontology Development Kit, actually, lol. But no more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #719
Overview
odkrunnernow instead ofrun.sh.Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?Build:
odkrunner- build #731New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?