DO NOT MERGE - Test build from develop
#729
Conversation
twhetzel
added
the
build
| @@ -48,6 +48,7 @@ MONDO:0000158 skos:exactMatch OMIMPS:142700 Developmental dysplasia of the hip | |||
| MONDO:0000159 skos:exactMatch OMIMPS:614675 Bone marrow failure syndrome semapv:UnspecifiedMatching | |||
There was a problem hiding this comment.
Are all the deletions in this file expected?
There was a problem hiding this comment.
Hmm, per the other comments above about this one, I'm not really sure what to do about this one. I believe that the purl for the wget for these mappings comes from the mondo repository. So something is happening there.
| @@ -1229,7 +1229,7 @@ MONDO:0001700 megaloblastic anemia oio:hasExactSynonym MGA1 Norwegian type DO | |||
| MONDO:0001700 megaloblastic anemia oio:hasExactSynonym megaloblastic anemia DOID:13382 megaloblastic anemia megaloblastic anemia DOID:13382 | |||
| MONDO:0001700 megaloblastic anemia oio:hasExactSynonym recessive hereditary megaloblastic anemia 1 DOID:13382 megaloblastic anemia recessive hereditary megaloblastic anemia 1 DOID:13382 | |||
| MONDO:0001700 megaloblastic anemia oio:hasExactSynonym recessive hereditary megaloblastic anaemia 1 DOID:13382 megaloblastic anemia http://purl.obolibrary.org/obo/OMO_0003005 recessive hereditary megaloblastic anaemia 1 DOID:13382 | |||
| MONDO:0001700 megaloblastic anemia oio:hasExactSynonym RH-MGA1 DOID:13382 megaloblastic anemia http://purl.obolibrary.org/obo/mondo#ABBREVIATION RH-MGA1 DOID:13382 http://purl.obolibrary.org/obo/mondo#ABBREVIATION | |||
| MONDO:0001700 megaloblastic anemia oio:hasExactSynonym RH-MGA1 DOID:13382 megaloblastic anemia http://purl.obolibrary.org/obo/mondo#ABBREVIATION http://purl.obolibrary.org/obo/mondo#ABBREVIATION RH-MGA1 DOID:13382 http://purl.obolibrary.org/obo/mondo#ABBREVIATION | |||
There was a problem hiding this comment.
@joeflack4 can you confirm the formatting of this row looks correct? Thanks!
There was a problem hiding this comment.
In my local mondo-edit:
id: MONDO:0001700
name: megaloblastic anemia
synonym: "RH-MGA1" EXACT ABBREVIATION [DOID:13382]
The diff is caused by the recent addition of ABBREVIATION. In my local mondo-edit, it wasn't there until I did a git pull. So now that it is in mondo-edit, it shows up in the
synonym_type_mondo column instead of just the synonym_type and exact_synonym_type columns.
There was a problem hiding this comment.
Is the formatting correct?
There was a problem hiding this comment.
I'm not 100% sure what you mean specifically by formatting, but yes, I opened the file, looked at all of the columns and their values and that row, and it looks correct.
|
@joeflack4 did you review this yet? |
There was a problem hiding this comment.
Lot of diffs in the EMC pipeline but I'm out of the loop on that and my guess is it is expected.
Resolves #ISSUE(s).
Overview
This PR:
Is a test build from
developto confirm that 1) the build still runs successfully and 2) the changes from the new features look as expected.Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?