-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize odkrunner
#719
Comments
@joeflack4 do you want to try this for updating to ODK 1.5.4? |
I'm not in a rush to do this. I did notice when updating my images locally that there was a new image, but unless there's a specific benefit to a patch version, I feel it's better to wait. Unless you or Nico know of a specific reason that we should upgrade to this version. Similar with this one. This is a nice-to-have. So I'm not in a rush though I could do it after completing my January release issues. I could do these in the same PR or separate; either way. |
I don't think there is anything "to do" to switch to ODK runner other than adding something to the documentation? We could possibly add a goal to upgrade ODK runner to the makefile but setting it up is a local job. |
Good point. Well, looks like it's only a couple hundred kb (that makes me happy); in that case personally I'd commit that. But if we do, I agree; would still update the docs about using it. But I guess the standard practice for a binary like this is manual setup, adding to global packages, if we just wanna go that route. |
As for ODK version, I suppose @matentzn doesn't see a reason to upgrade right now either? Or on the contrary, I wonder if you guys do want to upgrade the |
I think it makes sense to update versions frequently as the minor versions are all about upgrading sssom, oak, robot etc.. So I would be in favour of upgrading. Minor updates don't happen more than once every two or three months, the last two were a real exception |
Overview
We should utilize ODK runner instead of
run.sh
.Additional info
sh run.sh make update_repo
#435The text was updated successfully, but these errors were encountered: