Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SOP for updating the repo sh run.sh make update_repo #435

Open
2 of 4 tasks
matentzn opened this issue Feb 9, 2024 · 8 comments
Open
2 of 4 tasks

Document SOP for updating the repo sh run.sh make update_repo #435

matentzn opened this issue Feb 9, 2024 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@matentzn
Copy link
Member

matentzn commented Feb 9, 2024

New plan: odkrunner

Action items:

Original plan (obsolete)

Until 20th February

  1. Run:
    sh run.sh make update_repo
    

This is using run.sh.conf which has all the relevant environment variables, including ODK_TAG=dev. Contrary to what I told you @joeflack4 you cannot just pass ODK_TAG=dev to run.sh, because run.sh.conf has precedence.

After 20th February

  1. Edit src/ontology/run.sh.conf and set ODK_TAG=latest
  2. Run:
    sh run.sh make update_repo
    
  3. Edit src/ontology/run.sh.conf and set ODK_TAG=dev
  4. Commit changes.

@matentzn matentzn added the documentation Improvements or additions to documentation label Feb 9, 2024
@matentzn matentzn mentioned this issue Feb 9, 2024
3 tasks
@twhetzel
Copy link
Contributor

twhetzel commented Feb 9, 2024

What is the significance of Feb. 20? Is there an ODK release planned?

Edit: I've read #433 (review) and see this is the case.

@matentzn
Copy link
Member Author

matentzn commented Feb 9, 2024

What is the significance of Feb. 20? Is there an ODK release planned?

Yes, thats right!

@twhetzel twhetzel self-assigned this Feb 9, 2024
@twhetzel
Copy link
Contributor

twhetzel commented Feb 9, 2024

From what I heard from Joe yesterday, this seems fine.

@joeflack4
Copy link
Contributor

joeflack4 commented Feb 9, 2024

Trish and I were basically planning on this, so I'm mostly in agreement. I'll add some thoughts in a bit.

I was surprised to see that you merged #432. Based on what you've written in the OP, I'm guessing that currently dev is preferable to latest until the next Feb 20 ODK release. Is that correct?
edit: I see that Nico explained that is indeed correct!

@matentzn
Copy link
Member Author

matentzn commented Feb 9, 2024

Yes, for now dev is the way to go.

@joeflack4 joeflack4 mentioned this issue Feb 9, 2024
4 tasks
@joeflack4
Copy link
Contributor

Alright, the reason I didn't sign off on this yet is because I had this in the works. Please review first:

@twhetzel
Copy link
Contributor

twhetzel commented Dec 6, 2024

This should now be documented based on using the ODK runner based on this comment.

@joeflack4
Copy link
Contributor

Sounds good! Updated the OP w/ new steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants