Bug fixes: synonym_sync_combined_cases.robot.tsv
& build hangs
#727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #691
Overview
Fixes that sometimes
synonym_sync_combined_cases.robot.tsv
would be empty.Also fixes: Sometimes builds would pause in a particular place until some input was made in the terminal.
Additional info
Cause:
I was just about to start working on #691 when I asked Claude about why my builds were pausing; turns out these are related!
This explains why this happened to me usually, Nico sometimes, and Trish never. This doesn't happen unless you run a build on a fresh clone!
Additional tweaks made:
The "combined cases" file has become a permanent curation file. It made sense to formalize it as such in this PR. Formalizing it this way also made the bug fix easier to implement.
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/
?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingest
on this branch (afterdocker pull obolibrary/odkfull:dev
), and no errors occurred?Build:
New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?