DO NOT MERGE: Bug fixes: Synonym Sync - combined cases - build #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bug fix: synonym_sync_combined_cases.robot.tsv would sometimes be empty. - Bug fix: Sometimes builds would pause in a particular place until some input was made in the terminal. Turned out to be an artefact of the same underlying problem.
9 tasks
|
@twhetzel I will review tomorrow. I left Nico off review of this one; feel free to add him if that is preferable. |
joeflack4
added
the
build
joeflack4
commented
Dec 19, 2024
There was a problem hiding this comment.
These direct-source-indirect-mondo files are being added because that PR was merged recently, but they do not yet exist on develop. Expected~
There was a problem hiding this comment.
Very happy to see that this file was not deleted during this build! Which is what the PR is intended to fix.
There was a problem hiding this comment.
Also did not experience any "hanging" in the terminal with this build. So looks like that fix worked as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build for:
synonym_sync_combined_cases.robot.tsv& build hangs #727