feat: use ulong and topics and plumb through resumeAt subscription arguments
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer using ulong for topic sequence number and page. Even though this is not CLS compliant, both of these are represented as protobuf `uint64`s. The topic sequence page can grow unboundedly and we should retain precision.
Previously we dropped the `resumeAtSequence...` values from the public API. This commit plumbs through the values to the subscription wrapper.
nand4011
previously approved these changes
Nov 12, 2024
nand4011
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes TopicItem and TopicSystemEvent to store the sequence number/page as
ulong. This removes a checked cast under the hood.Also plumbs through
resumeAtTopicSequenceNumber(page) to the subscription wrapper.I tested these changes on both topics examples successfully without any changes on the example side.