refactor: push resumeAt defaults to subscription wrapper constructor

momentohq · Nov 12, 2024 · f34b24a · f34b24a
1 parent 1ba706a
commit f34b24a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Momento.Sdk/Internal/ScsTopicClient.cs b/src/Momento.Sdk/Internal/ScsTopicClient.cs
@@ -123,7 +123,7 @@ private async Task<TopicSubscribeResponse> SendSubscribe(string cacheName, strin
         {
             _logger.LogTraceExecutingTopicRequest(RequestTypeTopicSubscribe, cacheName, topicName);
             subscriptionWrapper = new SubscriptionWrapper(grpcManager, cacheName, topicName,
-                resumeAtTopicSequenceNumber ?? 0, resumeAtTopicSequencePage ?? 0, _exceptionMapper, _logger);
+                resumeAtTopicSequenceNumber, resumeAtTopicSequencePage, _exceptionMapper, _logger);
             await subscriptionWrapper.Subscribe();
         }
         catch (Exception e)
@@ -153,14 +153,14 @@ private class SubscriptionWrapper : IDisposable
         private bool _subscribed;
 
         public SubscriptionWrapper(TopicGrpcManager grpcManager, string cacheName,
-            string topicName, ulong resumeAtTopicSequenceNumber, ulong resumeAtTopicSequencePage,
+            string topicName, ulong? resumeAtTopicSequenceNumber, ulong? resumeAtTopicSequencePage,
             CacheExceptionMapper exceptionMapper, ILogger logger)
         {
             _grpcManager = grpcManager;
             _cacheName = cacheName;
             _topicName = topicName;
-            _lastSequenceNumber = resumeAtTopicSequenceNumber;
-            _lastSequencePage = resumeAtTopicSequencePage;
+            _lastSequenceNumber = resumeAtTopicSequenceNumber ?? 0;
+            _lastSequencePage = resumeAtTopicSequencePage ?? 0;
             _exceptionMapper = exceptionMapper;
             _logger = logger;
         }