494 selenium+docker #503
Merged
494 selenium+docker #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadronCollider
commented
Mar 16, 2024
tests/scripts/docker_check_tests.sh
Outdated
| if docker inspect --format='{{.State.Running}}' "$container_id" | grep -q "false"; then | ||
| echo "tests are finished" | ||
| EXIT_CODE=$(docker inspect "$container_id" --format='{{.State.ExitCode}}') | ||
| docker-compose -f docker-compose.yml -f docker-compose-selenium.yml logs selenium-tests |
There was a problem hiding this comment.
Тут бы пригодились о логи самой системы (или как минимум web+worker)
There was a problem hiding this comment.
Комментарий ещё актуален
There was a problem hiding this comment.
Добавила web и worker
HadronCollider
commented
Mar 16, 2024
tests/scripts/docker_check_tests.sh
Outdated
| container_id=$(docker-compose -f docker-compose.yml -f docker-compose-selenium.yml ps -q $service) | ||
|
|
||
|
|
||
| while true; do |
There was a problem hiding this comment.
Опасный вечный цикл - стоит либо на что-то заменить, либо запускать скрипт вместе с timeout (команда от bash), либо установить таймаут на Github action
There was a problem hiding this comment.
Комментарий ещё актуален
There was a problem hiding this comment.
Изменила на условие
while [ "$(docker inspect --format='{{.State.Running}}' "$container_id")" == "true" ]; do
This was referenced Mar 17, 2024
Closed
Closed
fix mistake with main_header
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #494