485 selenium test statistic #493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmm
reviewed
Jan 22, 2024
tests/README.md
Outdated
| (selenium==4.16.0 (in this version you don't need to download geckodriver)) | ||
|
|
||
| pip install webdriver-manager (to avoid problem with binary. And you should have Firefox installed not in 'snap') | ||
| webdriver-manager==4.0.1 |
There was a problem hiding this comment.
Нужно составить свой requirements для данного каталога
There was a problem hiding this comment.
добавлен tests/requirements.txt
zmm
reviewed
Jan 22, 2024
tests/test_statistic.py
Outdated
| login.send_keys(login_param) | ||
| password = self.getDriver().find_element(By.ID, "password_text_field") | ||
| password.clear() | ||
| password.send_keys(password_param) |
There was a problem hiding this comment.
Предлагаю логику авторизации вынести в отдельный метод / функцию, который будет переиспользоваться в тестах.
There was a problem hiding this comment.
Авторизация добавлена как метод в BasicSeleniumTest
HadronCollider
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Объедините, пожалуйста, с наработками #482
Плюс комментарий по тесту ниже
tests/test_statistic.py
Outdated
Comment on lines
12
to
13
| obj = self.getDriver().find_element(By.CLASS_NAME, "fixed-table-container") | ||
| self.assertNotEquals(obj, None) |
There was a problem hiding this comment.
Я бы предложил усилить тест - проверить наличие строк в таблице (или их отсутствие, если проверок нет) - т.е. дождаться загрузки данных таблицы
- очень часто были случаи, что обработка запроса на получение статистики (т.е. данных о самих проверках, которые выводятся затем в таблице) ломалась, т.е. была вечная
Loading, please wait- было бы хорошо, если этот (или другой тест) проверял бы этот момент
|
Работа ведется в #503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Тест, проверяющий просмотр статистики согласно заданию
#485