Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

485 selenium test statistic #493

Closed
wants to merge 9 commits into from
21 changes: 21 additions & 0 deletions tests/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
## For beginning:

Install:
pip install selenium
(selenium==4.16.0 (in this version you don't need to download geckodriver))

pip install webdriver-manager (to avoid problem with binary. And you should have Firefox installed not in 'snap')
webdriver-manager==4.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно составить свой requirements для данного каталога

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавлен tests/requirements.txt


## Test for open statistic:
class StatisticTestSelenium(BasicSeleniumTest) with 1 test

Test check: if page "/check_list" opens

## Run run_tests

use login and password from .env

```bash
$ python tests/main.py --host host --login login --password password
```
30 changes: 30 additions & 0 deletions tests/basic_selenium_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import unittest
from selenium import webdriver
from selenium.webdriver.firefox.service import Service as FirefoxService
from webdriver_manager.firefox import GeckoDriverManager #pip install webdriver-manager

class BasicSeleniumTest(unittest.TestCase):

driver = webdriver.Firefox(service=FirefoxService(GeckoDriverManager().install())) #you should have Firefox, installed not from snap
def __init__(self, methodName='runTest', param=None):
super(BasicSeleniumTest, self).__init__(methodName)
self.param = param

@staticmethod
def parametrize(testcase_class, param=None):
testloader = unittest.TestLoader()
testnames = testloader.getTestCaseNames(testcase_class)
suite = unittest.TestSuite()
for name in testnames:
suite.addTest(testcase_class(name, param=param))
return suite

def getUrl(self, relativePath):
return self.param[0] + relativePath

def getDriver(_):
return BasicSeleniumTest.driver

@classmethod
def closeDriver(cls):
cls.driver.close()
26 changes: 26 additions & 0 deletions tests/main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import unittest
import sys
import argparse
from basic_selenium_test import BasicSeleniumTest
from test_statistic import StatisticTestSelenium

def parse_arguments():
parser = argparse.ArgumentParser(description='Run Selenium tests with specified host, login, and password.')
parser.add_argument('--host', type=str, default='http://127.0.0.1:8080', help='Host address for testing')
parser.add_argument('--login', type=str, required=True, help='insert Username')
parser.add_argument('--password', type=str, required=True, help='insert Password')
return parser.parse_args()

def main():
args = parse_arguments()

suite = unittest.TestSuite()
suite.addTest(BasicSeleniumTest.parametrize(StatisticTestSelenium, param=(args.host, args.login, args.password)))

returnCode = not unittest.TextTestRunner(verbosity=2).run(suite).wasSuccessful()

BasicSeleniumTest.closeDriver()
sys.exit(returnCode)

if __name__ == '__main__':
main()
25 changes: 25 additions & 0 deletions tests/test_statistic.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import os
from basic_selenium_test import BasicSeleniumTest
from selenium.webdriver.common.by import By

class StatisticTestSelenium(BasicSeleniumTest):

def test_open_statistic(self):
host, login_param, password_param = self.param
URL = self.getUrl('/login')
self.getDriver().get(URL)
self.getDriver().implicitly_wait(30)
login = self.getDriver().find_element(By.ID, "login_text_field")
login.clear()
login.send_keys(login_param)
password = self.getDriver().find_element(By.ID, "password_text_field")
password.clear()
password.send_keys(password_param)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю логику авторизации вынести в отдельный метод / функцию, который будет переиспользоваться в тестах.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Авторизация добавлена как метод в BasicSeleniumTest

login_button = self.getDriver().find_element(By.ID, "login_button")
login_button.click()
URL = self.getUrl('/check_list')
self.getDriver().get(URL)
self.getDriver().implicitly_wait(30)
obj = self.getDriver().find_element(By.CLASS_NAME, "fixed-table-container")
self.assertNotEquals(obj, None)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы предложил усилить тест - проверить наличие строк в таблице (или их отсутствие, если проверок нет) - т.е. дождаться загрузки данных таблицы

  • очень часто были случаи, что обработка запроса на получение статистики (т.е. данных о самих проверках, которые выводятся затем в таблице) ломалась, т.е. была вечная Loading, please wait - было бы хорошо, если этот (или другой тест) проверял бы этот момент

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправила.


Loading