Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minhash deduplicator based on RAY and Redis #489

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Nov 15, 2024

As the title says

Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, plz see a few suggestions as commented

docs/Operators_ZH.md Show resolved Hide resolved
configs/config_all.yaml Outdated Show resolved Hide resolved
add_uid_column, batch_format='pyarrow').materialize()
dataset_with_id.map_batches(calculate_minhash,
batch_format='pyarrow').groupby(
HashKeys.minhash).aggregate(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we are (ideally) optimizing this via multiple distributed UnionSets, it is worth profiling this line and (then co-optimizing with Ray-Team)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants