Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement NGFF source validation #136

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

martinschorb
Copy link
Contributor

addresses #135

@martinschorb
Copy link
Contributor Author

I could not find tests for the validations (checking if errors are thrown). That's a bit redundant anyways.

@constantinpape
Copy link
Contributor

I could not find tests for the validations (checking if errors are thrown). That's a bit redundant anyways.

Yes, I never really got around to implement these. There's only a superficial test here.

In any case, the changes here look good and straightforward, and the code is being run by a couple of tests that add and then validate ome.zarr data ;).

@constantinpape constantinpape merged commit d1ac181 into master Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants