Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Github issue or other discussion
#707
What does this PR do?
This makes some string comparisons case insensitive to allow more flexible data to be accepted.
What changes were made?
I this PR just adds a call to
.lower()
in the method chaining, so code like.startswith()
and.endswith()
becomes.lower().startswith()
and.lower().endswith()
How to test / verify this PR?
Need to pass a .xlsx file that has at least one of the file suffix letters are in upper case.
Also, need to pass a "file" field value of "http" were one of the protocol's letters are in upper case.Interested Parties
@mjordan
metadata_case_insensitive.Xlsx
Checklist
pycodestyle --show-source --show-pep8 --ignore=E402,W504 --max-line-length=200 yourfile.py
?setup.py
?