Make some string comparisons case insensitive

[ysuarez]

noticed some bits of code using the Python built-in string methods of .startswith() and .endswith() that are case sensitive. Though for some of those situations it may be better the checks were case insensitive.

The check are mostly related to checking if a “file” field value starts with “http” and at least one situation were we check if a file suffix ends in “.xslx.” Usually these strings will be lowercase, but we may find situations where the incoming data is upper case or mix case.

For example,

islandora_workbench/workbench

Lines 2123 to 2126 in b38d37e

	if config['task'] != 'create_from_files' and config['input_csv'].startswith('http') is True:
	get_csv_from_google_sheet(config)
	if config['task'] != 'create_from_files' and config['input_csv'].endswith('.xlsx') is True:
	get_csv_from_excel(config)

I have a WIP PR that just adds a call to .lower() in the method chaining, to address this issues. Let me know this is a change that I should implement to all the relevant .startswith() and .endswith() uses.

[mjordan]

Thanks for catching this @ysuarez , I'll when you're ready.

[ysuarez]

I just put in the PR, but I realized my code was not 100% ready so I reverted a few things from this first PR. Though I seem to be correctly catching an .xlsx suffix with uppercase letters.

Need to work more to account for uppercase http prefix in 1) "file" values and 2) Google Sheets URLs. I will create another PR(s) next week.

[ysuarez]

@mjordan I just pushed a new commit to PR #708 to make the check of an URL in input_csvcase-insensitive when the code just checks the 'http' prefix. The code passed the local tests I ran.

I will need another week or so to work on making the various metadata.csv file column 'http' prefix checks case-insentive.

Would you like to merge these changes so far and I can make another PR, or should I keep working on making more 'http' check case-insensitive and then we merge? Thanks

[ysuarez]

@mjordan I just updated #708 to add the final set uses of lower() in front of .startswith('http') and did some trial runs with mix case uses of 'http' and the use of lower() worked.

I think this can be merged now. Let em know what changes you would like to me to make.

[mjordan]

Thanks, I'll review.