mark rendering improvements #13969
Open
mark rendering improvements #13969
+121
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
reviewed
Dec 3, 2024
Comment on lines
+138
to
+140
| qreal w = std::round(metrics.horizontalAdvance(text) * | ||
| devicePixelRatio / devicePixelRatio) + | ||
| space + space + 1.0; |
There was a problem hiding this comment.
Suggested change
| qreal w = std::round(metrics.horizontalAdvance(text) * | |
| devicePixelRatio / devicePixelRatio) + | |
| space + space + 1.0; | |
| qreal w = std::round(metrics.horizontalAdvance(text)) + | |
| space + space + 1.0; |
Or should the division be after the round?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were originally made in the rendergraph PR (and in code already using rendergraph):
#13599
but I am splitting that PR into multiple ones. This is a OpenGL backport of those changes, but it will result in a smaller delta once I have the PR for the rendergraph base waveform mark renderers.
The improvements here are:
Not using empty space in the mark textures to align them. For left and right aligned markers, half the image would be fully transparent. With this PR only the space needed it uses, and the mark is drawn with an offset to align them to the marker position.
Round drawing to pixels. With OpenGL this doesn't seem necessary, but with QML / Qt Scenegraph this causes artifacts in the rendering.