Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user vat id #940

Merged
merged 2 commits into from
Jan 12, 2024
Merged

feat: add user vat id #940

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e44da2a
feat: add user vat id
asadali145 Dec 5, 2023
73c62a7
update description
asadali145 Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ol_dbt/models/intermediate/mitxpro/_int_mitxpro__models.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,6 +1255,8 @@ models:
description: timestamp, user last log in
- name: user_address_country
description: str, country code for the user's address
- name: user_vat_id
description: str, vat id of the user
- name: user_is_active
description: boolean, indicating if user is active or not
- name: user_street_address
Expand Down
1 change: 1 addition & 0 deletions src/ol_dbt/models/intermediate/mitxpro/int__mitxpro__users.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ select
, users_legaladdress.user_address_city
, users_legaladdress.user_street_address
, users_legaladdress.user_address_postal_code
, users_legaladdress.user_vat_id
, users_profile.user_birth_year
, users_profile.user_company
, users_profile.user_job_title
Expand Down
2 changes: 2 additions & 0 deletions src/ol_dbt/models/staging/mitxpro/_stg_mitxpro__models.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,8 @@ models:
description: string, user first name
tests:
- not_null
- name: user_vat_id
description: string, user vat id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some description on what user vat id is? I think its useful to document that.

- name: user_street_address
description: string, user street address
tests:
Expand Down
1 change: 1 addition & 0 deletions src/ol_dbt/models/staging/mitxpro/stg__mitxpro__app__postgres__users_legaladdress.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ with source as (
, city as user_address_city
, state_or_territory as user_address_state_or_territory
, postal_code as user_address_postal_code
, vat_id as user_vat_id
, concat_ws(
chr(10)
, nullif(street_address_1, '')
Expand Down