feat: add user vat id #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asadali145
force-pushed
the
asad/add-user-vat-id
branch
from
f874bd9
to
e44da2a
Compare
|
I am not able to refresh the schema. Also, getting an error when I try to test the models locally. Is there anything that I am missing? |
There was a problem hiding this comment.
The new field should also add to source file https://github.com/mitodl/ol-data-platform/blob/main/src/ol_dbt/models/staging/mitxpro/_mitxpro__sources.yml#L853
Other than small comment for field description, it looks good to me
| @@ -944,6 +944,8 @@ models: | |||
| description: string, user first name | |||
| tests: | |||
| - not_null | |||
| - name: user_vat_id | |||
| description: string, user vat id | |||
There was a problem hiding this comment.
Can we add some description on what user vat id is? I think its useful to document that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes mitodl/mitxpro#2762
Description (What does it do?)
Adds user vat id.
How can this be tested?
dbt build -s +stg__mitxpro__app__postgres__users_legaladdress --vars 'schema_suffix: asad' --target dev_productiondbt build -s +int__mitxpro__users --vars 'schema_suffix: asad' --target dev_production