Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating enrollment set is_active explicitly in the enrollment api call #2300

Merged
merged 7 commits into from
Jul 31, 2024
Merged

When creating enrollment set is_active explicitly in the enrollment api call #2300

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d9659a4
set is_active on enrollment
annagav Jul 17, 2024
73d752d
enrollment_attributes
annagav Jul 22, 2024
18dd89c
if is_active is false call api again
annagav Jul 27, 2024
844ed49
test
annagav Jul 29, 2024
f8529b0
print
annagav Jul 29, 2024
0fff7b7
mocking
annagav Jul 29, 2024
493ca45
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions openedx/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@ def enroll_in_edx_course_runs(
mode=mode,
username=username,
force_enrollment=force_enrollment,
enrollment_attributes={"name": "is_active", "value": True},
Copy link
Contributor

@arslanashraf7 arslanashraf7 Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setting is_active in enrollment_attributes would not work. We will need to send is_active as an independent key in the post data.

Here are some of the details behind:

If we take a look at this enrollment code in Open edX you will notice that they are getting the is_active key right from the post data field and not the enrollment_attributes. So, I think this change would not do the trick for us.

In my opinion here is what we would need to do:

  1. Allow create_student_enrollment to take an is_active attr which can be True by default
  2. Add is_active in enrollment_data
  3. Update the usages of create_student_enrollment in MITx Online project as per needs.

)
results.append(enrollment)
except HTTPError as exc: # noqa: PERF203
Expand Down
Loading