When creating enrollment set is_active explicitly in the enrollment api call

[annagav]

What are the relevant tickets?

Fix #2225 and #1797

Description (What does it do?)

If use enrolls, unenrolls, and enrolls again, the course run enrollment in edx should be active, otherwise the user can't access the course on edx, just like it happened for this user https://github.com/mitodl/hq/issues/4367.

On open edx is_active = False is equivalent to being unenrolled.

How can this be tested?

Locally you can test if by enrolling in a course for an audit track, then unenrolling, then paying again. You can pay with a coupon too.
The api would get called again. This double call of create enrollment api is going to set is_active to true on repeated call.

[pdpinch]

Why?

[annagav]

Why?

If user re-enrolls their enrollment stays inactive and they can't access the course through the courseware.

[arslanashraf7]

I think setting is_active in enrollment_attributes would not work. We will need to send is_active as an independent key in the post data.

Here are some of the details behind:

If we take a look at this enrollment code in Open edX you will notice that they are getting the is_active key right from the post data field and not the enrollment_attributes. So, I think this change would not do the trick for us.

In my opinion here is what we would need to do:

1. Allow create_student_enrollment to take an is_active attr which can be True by default
2. Add is_active in enrollment_data
3. Update the usages of create_student_enrollment in MITx Online project as per needs.

[annagav]

So just adding here more clarification on the issue.

The enrollment stays inactive only following a "verified" enrollment as a result of payment for the course run.

If re-enroll in as audit again, then is works correctly.

[annagav]

So I have been playing with the api and what I found is this:

Set up:

There is an existing enrollment that has is_active=False( meaning the user unenrolled).

Action:

If I make an api ( edx_client.enrollments.create_student_enrollment)call with the same MODE is_active gets set to True.
If I make the same api call but the MODE is not the same (changing from audit to verified or vice versa), then the MODE gets updated but is_active stays False.