Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test drop onto itself and hide when dragging #59

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Oct 23, 2022

@mvorisek mvorisek marked this pull request as draft October 23, 2022 10:49
@mvorisek mvorisek force-pushed the test_droppable_hidden_itself branch 3 times, most recently from 38c6ef7 to 1ff8cf7 Compare October 23, 2022 12:55
@mvorisek mvorisek marked this pull request as ready for review October 23, 2022 12:56
@mvorisek
Copy link
Contributor Author

mvorisek commented Oct 23, 2022

test is correct and working

In Selenium 2.53.1 (latest 2.x) the test does not pass, for some reasons, button up event is not fired.

see 38c6ef7 debug output:

Drop here, mouseover, mouseover, mouseover, mousemove, mousemove, mousemove, mousedown, mousedown,
mousedown, mouseout, mouseout, mouseout, mouseover, mouseover, mouseover, mouseover

In Selenium 3.x it passes.

Drop here, mouseout, mouseover, ..., mouseup, Dropped small!, click, click, dblclick, dblclick, mouseout,
mouseout, mouseout, mouseout, mouseover, mouseover, mouseover

notice no mouseup nor Dropped small! in Selenium 2.53.1 browser event/debug log

Selenium 2.53.1 is very old and the test should be skipped in minkphp/MinkSelenium2Driver#359 and then tested in minkphp/MinkSelenium2Driver#354

@mvorisek
Copy link
Contributor Author

@stof please merge this test as requested in minkphp/MinkSelenium2Driver#359 (comment)

test can be tested locally by clicking the smaller box - notice the drag and drop works even without any mouse move and also when you hold the mouse, the box is not visible

image

I will then take care of skipping the test for Selenium 2.53.1 and testing with 3.x.

@mvorisek mvorisek force-pushed the test_droppable_hidden_itself branch from 1ff8cf7 to be3bd8e Compare October 23, 2022 22:58
@mvorisek
Copy link
Contributor Author

@stof this is the test you requested in minkphp/MinkSelenium2Driver#359 (comment), can you please review it and merge?

@stof stof merged commit 69ffd8f into minkphp:master Apr 1, 2024
@mvorisek mvorisek deleted the test_droppable_hidden_itself branch April 1, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants