Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed return type of the "testDragDropOntoHiddenItself" test #95

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fixed return type of the "testDragDropOntoHiddenItself" test #95

merged 1 commit into from
Jun 26, 2024
+1 −1

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Apr 9, 2024 •
edited
Loading

Corrects PhpStan report on #59, which was merged last week.

 ------ ---------------------------------------------------------------------------------------------------------------- 
  Line   tests/Js/JavascriptTest.php                                                                                     
 ------ ---------------------------------------------------------------------------------------------------------------- 
  34     Method Behat\Mink\Tests\Driver\Js\JavascriptTest::testDragDropOntoHiddenItself() has no return type specified.  
 ------ ----------------------------------------------------------------------------------------------------------------

P.S.
I'm not sure why, but no GitHub Actions were executed on that PR and therefore PhpStan wasn't able to report this prior to PR merging.

@aik099 aik099 mentioned this pull request Apr 9, 2024
Merged
@stof stof merged commit 3620283 into minkphp:master Jun 26, 2024
2 checks passed
@aik099 aik099 deleted the test-suite-method-return-type-fix branch June 28, 2024 09:42
@aik099
Copy link
Member Author

aik099 commented Jun 28, 2024

Thank you, @stof .

@aik099 aik099 mentioned this pull request Nov 1, 2024
Closed
@aik099
Copy link
Member Author

aik099 commented Nov 1, 2024

Problem from this test on Selenium 2: minkphp/MinkSelenium2Driver#391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aik099 @stof