Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5415: Add url to content security policy so images will display #7575

Merged
merged 2 commits into from
Jan 14, 2025
+3 −1
Merged

AP-5415: Add url to content security policy so images will display #7575

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0addace
AP-5415: Add url to content security policy so images will display
agoldstone93 Jan 13, 2025
ab7746c
AP-5415: Add yaml-dev to fix build step issue
agoldstone93 Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/initializers/content_security_policy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
GOOGLE_ANALYTICS_DOMAIN,
"www.googletagmanager.com",
"https://truelayer-client-logos.s3-eu-west-1.amazonaws.com",
"https://truelayer-provider-assets.s3.amazonaws.com"
"https://truelayer-provider-assets.s3.amazonaws.com",
Comment on lines 10 to +11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone know if these two lines are being used anywhere anymore or can be removed? Or know a way I can easily check this?

Copy link
Contributor

@colinbruce colinbruce Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Know? No.
I suspect that these were the original locations of the images provided by Truelayer, why there are two of them? 🤷‍♂️
Maybe there was a test and production location?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colinbruce Yeah, I assumed the same thing - that that's the original location. I was trying to work out if it's safer to leave them in or remove them

"https://providers-assets.truelayer.com"
policy.object_src :none
policy.style_src :self, :unsafe_inline
policy.script_src :self,
Expand Down
Loading