Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5415: Add url to content security policy so images will display #7575

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

agoldstone93
Copy link
Contributor

What

Link to story

Add url to content security policy so images will display

Screenshot

image

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Comment on lines 10 to +11
"https://truelayer-client-logos.s3-eu-west-1.amazonaws.com",
"https://truelayer-provider-assets.s3.amazonaws.com"
"https://truelayer-provider-assets.s3.amazonaws.com",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone know if these two lines are being used anywhere anymore or can be removed? Or know a way I can easily check this?

Copy link
Contributor

@colinbruce colinbruce Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Know? No.
I suspect that these were the original locations of the images provided by Truelayer, why there are two of them? 🤷‍♂️
Maybe there was a test and production location?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colinbruce Yeah, I assumed the same thing - that that's the original location. I was trying to work out if it's safer to leave them in or remove them

@agoldstone93 agoldstone93 marked this pull request as ready for review January 13, 2025 14:12
@agoldstone93 agoldstone93 requested a review from a team as a code owner January 13, 2025 14:12
@agoldstone93 agoldstone93 force-pushed the ap-5415-fix-missing-bank-logos branch from c8e5eba to 0addace Compare January 14, 2025 08:14
@agoldstone93 agoldstone93 force-pushed the ap-5415-fix-missing-bank-logos branch from e19e173 to ab7746c Compare January 14, 2025 08:53
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired on the subsequent docker update and approved to unblock deploys

@agoldstone93 agoldstone93 merged commit 6322197 into main Jan 14, 2025
16 checks passed
@agoldstone93 agoldstone93 deleted the ap-5415-fix-missing-bank-logos branch January 14, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants