-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP-5415: Add url to content security policy so images will display #7575
Conversation
"https://truelayer-client-logos.s3-eu-west-1.amazonaws.com", | ||
"https://truelayer-provider-assets.s3.amazonaws.com" | ||
"https://truelayer-provider-assets.s3.amazonaws.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone know if these two lines are being used anywhere anymore or can be removed? Or know a way I can easily check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Know? No.
I suspect that these were the original locations of the images provided by Truelayer, why there are two of them? 🤷♂️
Maybe there was a test and production location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colinbruce Yeah, I assumed the same thing - that that's the original location. I was trying to work out if it's safer to leave them in or remove them
c8e5eba
to
0addace
Compare
e19e173
to
ab7746c
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paired on the subsequent docker update and approved to unblock deploys
What
Link to story
Add url to content security policy so images will display
Screenshot
Checklist
Before you ask people to review this PR:
bundle exec rake
git rebase main
.