Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4170: Correct validation for dwp override #5920

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

agoldstone93
Copy link
Contributor

What

Link to story

Delete dwp override on page load

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 marked this pull request as ready for review October 30, 2023 12:19
@agoldstone93 agoldstone93 requested a review from a team as a code owner October 30, 2023 12:19
@agoldstone93 agoldstone93 added the ready for review Please review label Oct 30, 2023
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jsugarman jsugarman added approved Approved by code reviewers and removed ready for review Please review labels Oct 30, 2023
@agoldstone93 agoldstone93 force-pushed the ap-4170-correct-validation-for-dwp-override branch from b616e47 to 65ba0d8 Compare October 31, 2023 08:41
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

If a DWP override has already been created and the user
returns to the confirm dwp page, if they change their
mind and accept the dwp result, delete the existing
DWP override
@agoldstone93 agoldstone93 force-pushed the ap-4170-correct-validation-for-dwp-override branch from 65ba0d8 to cddf8e6 Compare October 31, 2023 11:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@agoldstone93 agoldstone93 merged commit cd01095 into main Oct 31, 2023
7 checks passed
@agoldstone93 agoldstone93 deleted the ap-4170-correct-validation-for-dwp-override branch October 31, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants