AP-4170 delete dwp override if dwp result is correct

If a DWP override has already been created and the user
returns to the confirm dwp page, if they change their
mind and accept the dwp result, delete the existing
DWP override

app/controllers/providers/confirm_dwp_non_passported_applications_controller.rb

@@ -14,6 +14,7 @@ def update
       @form = Providers::ConfirmDWPNonPassportedApplicationsForm.new(form_params)
 
       if @form.valid?
+        remove_dwp_override if correct_dwp_result?
         update_joint_benefit_response
         update_application_state
         HMRC::CreateResponsesService.call(legal_aid_application) if make_hmrc_call?
@@ -25,6 +26,10 @@ def update
 
   private
 
+    def remove_dwp_override
+      legal_aid_application.dwp_override&.destroy!
+    end
+
     def partner
       @partner = legal_aid_application.partner
     end

spec/requests/providers/confirm_dwp_non_passported_applications_controller_spec.rb

@@ -122,6 +122,12 @@
           patch_request
           expect(HMRC::CreateResponsesService).to have_received(:call).once
         end
+
+        it "successfully deletes any existing dwp override" do
+          create(:dwp_override, legal_aid_application: application)
+          patch_request
+          expect(application.reload.dwp_override).to be_nil
+        end
       end
 
       context "and the solicitor wants to override the results with a non joint benefit" do