Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-4314: Update Puppeteer #5710

Merged
merged 5 commits into from
Oct 16, 2023
Merged

AP-4314: Update Puppeteer #5710

merged 5 commits into from
Oct 16, 2023

Conversation

naseberry
Copy link
Contributor

@naseberry naseberry commented Sep 6, 2023 •
edited
Loading

What

Update puppeteer dependency to use the latest version

Puppeteer was previously fixed to an older version (v19.2.0) in order to allow pdf generation to work.
The fixed version of puppeteer is dated and no longer supported, therefore this branch was to test our functionality using the latest version of puppeteer.

Reference: #4700

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@naseberry naseberry changed the title WIP - node, update puppeteer WIP - Puppeteer Sep 6, 2023
@naseberry naseberry force-pushed the ph/ap-4314-modify-puppeteer-dependency branch 2 times, most recently from 421ddf8 to e5228b1 Compare September 7, 2023 14:55
@naseberry naseberry changed the title WIP - Puppeteer AP-4314: Update Puppeteer Sep 7, 2023
@naseberry naseberry force-pushed the ph/ap-4314-modify-puppeteer-dependency branch from 3f2577a to 2c307ce Compare October 13, 2023 15:26
@naseberry naseberry marked this pull request as ready for review October 16, 2023 13:55
@naseberry naseberry requested a review from a team as a code owner October 16, 2023 13:55
colinbruce
colinbruce approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
🤞 for the morning! 😄

@naseberry naseberry force-pushed the ph/ap-4314-modify-puppeteer-dependency branch from de803df to 558556f Compare October 16, 2023 15:00
@naseberry naseberry added Ready to merge Has passed UAT testing and can be merged into master and removed Discussion labels Oct 16, 2023
@naseberry
AP-4314: Update Puppeteer
aec6256 
Removed fixed version of puppeteer, enable app to install the latest version of puppeteer
@naseberry
AP-4314: Remove puppeteer from dependabot ignore list
0501a62 
As we no longer need to have a fixed version of puppeteer,
allow dependabot to create PRs to bump version
@naseberry
AP-4314: CYC, remove duplicate packages from docker setup
da4286b 
Clean as You Code: the following apk packages were being added twice:
ttf-freefont
nodejs
yarn
@naseberry
AP-4314: CYC, bump alpine image to v3.18
53a0f12
@naseberry
AP-4314: CYC, update dependabot grouping name
8dd6e20
@naseberry naseberry force-pushed the ph/ap-4314-modify-puppeteer-dependency branch from 558556f to 8dd6e20 Compare October 16, 2023 15:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@naseberry naseberry merged commit 4cc5564 into main Oct 16, 2023
7 checks passed
@naseberry naseberry deleted the ph/ap-4314-modify-puppeteer-dependency branch October 16, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinbruce colinbruce colinbruce approved these changes

Assignees
No one assigned
Labels
Ready to merge Has passed UAT testing and can be merged into master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naseberry @colinbruce