-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roles and permissions prior to Migration #6160
base: main
Are you sure you want to change the base?
Conversation
Terraform Component 🧱:
|
Terraform Component 🧱:
|
…/analytical-platform into migration-github-roles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the roles these are meant to be replacing for easier review. Preferrably to the code defining them, but if that isn't possible, a console link will do.
"stateLockingDetails": [], | ||
"ssmParameterConfig": [] | ||
}, | ||
"data-engineering-database-access": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure this at a minimum uses a state for Pulumi and now for terraform, so this will need amending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both repositories are Pulumi Python and use the bucket s3://data-engineering-pulumi.analytics.justice.gov.uk/.pulumi/
and within the stacks
folder are the files de-database-access.json
and create-a-derived-table-infra.json
which i have inferred are the state files for Pulumi. The stateConfig has been updated accordingly. I have been unable to find any reference to a terraform.tfstate
in the data-engineering-database-access
repository
"targets": [], | ||
"stateLockingDetails": [], | ||
"ssmParameterConfig": [], | ||
"lakeFormationSharePolicy": true | ||
}, | ||
"create-a-derived-table-infrastructure": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double-check this doesn't use a state? There's a mention of pulumi in the docs so I'd want to be careful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both repositories are Pulumi Python and use the bucket s3://data-engineering-pulumi.analytics.justice.gov.uk/.pulumi/
and within the stacks
folder are the files de-database-access.json
and create-a-derived-table-infra.json
which i have inferred are the state files for Pulumi. The stateConfig has been updated accordingly.
Roles being replaced by this PR data-engineering-database-access create-a-derived-table-infrastructure Console link for github-actions-infrastructure |
Pull Request Objective
This piece of work is being tracked in
this
GitHub Issue.
As part of the work outlined in the ticket above this PR creates the roles for the following repositories
moj-analytical-services/data-engineering-database-access
role to be replaced - arn:aws:iam::{DATA_ACCOUNT_ID}:role/github-actions-infrastructure
ministryofjustice/create-a-derived-table-infrastructure
rrole to be replaced - arn:aws:iam::{DATA_ACCOUNT_ID}:role/github-actions-infrastructure
Console link for github-actions-infrastructure