Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles and permissions prior to Migration #6160

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+34 −4
Open

Add roles and permissions prior to Migration #6160

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
464a8d3
add code for cadet role
BrianEllwood Nov 19, 2024
a80e820
add code for data eng role
BrianEllwood Nov 19, 2024
bf34adf
add code for helm chart role
BrianEllwood Nov 20, 2024
02bcb90
remove code for helm chart role
BrianEllwood Nov 20, 2024
a7bb94d
prettier canges
BrianEllwood Nov 22, 2024
63aac01
Merge branch 'main' into migration-github-roles
BrianEllwood Nov 22, 2024
acf65c7
undo change
BrianEllwood Nov 22, 2024
1f35bd9
Merge branch 'migration-github-roles' of github.com:ministryofjustice…
BrianEllwood Nov 22, 2024
05340c5
add state file buckets
BrianEllwood Nov 26, 2024
1e6540a
prettier changes
BrianEllwood Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 34 additions & 4 deletions terraform/aws/analytical-platform/oidc/configuration/assumable-roles.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@
"stateLockingDetails": [],
"ssmParameterConfig": [
{
"ssmParameterArnPrefixes": ["ap-uploader/env/", "ap-uploader/dev/", "ap-uploader/prod/"],
"ssmParameterArnPrefixes": [
"ap-uploader/env/",
"ap-uploader/dev/",
"ap-uploader/prod/"
],
"ssmParameterRegion": "eu-west-1"
}
]
Expand Down Expand Up @@ -176,12 +180,38 @@
"modernisation-platform-lake-formation-share": {
"account": "analytical-platform-data-production",
"stateConfig": [],
"repositories": [
"ministryofjustice/modernisation-platform-environments"
],
"repositories": ["ministryofjustice/modernisation-platform-environments"],
"targets": [],
"stateLockingDetails": [],
"ssmParameterConfig": [],
"lakeFormationSharePolicy": true
},
"create-a-derived-table-infrastructure": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double-check this doesn't use a state? There's a mention of pulumi in the docs so I'd want to be careful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both repositories are Pulumi Python and use the bucket s3://data-engineering-pulumi.analytics.justice.gov.uk/.pulumi/ and within the stacks folder are the files de-database-access.json and create-a-derived-table-infra.json which i have inferred are the state files for Pulumi. The stateConfig has been updated accordingly.

"account": "analytical-platform-data-production",
"stateConfig": [
{
"stateBucket": "data-engineering-pulumi.analytics.justice.gov.uk/",
"stateBucketKey": ".pulumi/"
}
],
"repositories": ["ministryofjustice/create-a-derived-table-infrastructure"],
"targets": ["analytical-platform-data-production"],
"stateLockingDetails": [],
"ssmParameterConfig": []
},
"data-engineering-database-access": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure this at a minimum uses a state for Pulumi and now for terraform, so this will need amending.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both repositories are Pulumi Python and use the bucket s3://data-engineering-pulumi.analytics.justice.gov.uk/.pulumi/ and within the stacks folder are the files de-database-access.json and create-a-derived-table-infra.json which i have inferred are the state files for Pulumi. The stateConfig has been updated accordingly. I have been unable to find any reference to a terraform.tfstate in the data-engineering-database-access repository

"account": "analytical-platform-data-production",
"stateConfig": [
{
"stateBucket": "data-engineering-pulumi.analytics.justice.gov.uk/",
"stateBucketKey": ".pulumi/"
}
],
"repositories": [
"moj-analytical-services/data-engineering-database-access"
],
"targets": ["analytical-platform-data-production"],
"stateLockingDetails": [],
"ssmParameterConfig": []
}
}