Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use is_none_or for clippy::nonminimal_bool and resolve clippy::needless_raw_string_hashes #231

Merged
merged 6 commits into from
Nov 8, 2024
Merged

refactor: use is_none_or for clippy::nonminimal_bool and resolve clippy::needless_raw_string_hashes #231

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1a4450
refactor: fix `clippy::nonminimal_bool` and `clippy::ref_option` issues
wmmc88 Oct 5, 2024
b6a8653
allow nonminimal_bool until is_some_or is stabilized
wmmc88 Oct 6, 2024
aa7c9ce
Revert "allow nonminimal_bool until is_some_or is stabilized"
wmmc88 Oct 6, 2024
0ed473c
Merge branch 'main' into stable-is-some-or-nonminimal-bool
NateD-MSFT Oct 22, 2024
c67d504
fix instance of clippy::needless_raw_string_hashes
wmmc88 Nov 4, 2024
de6177e
pin to known working winget version
wmmc88 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions crates/wdk-build/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,7 @@ pub fn validate_wdk_version_format<S: AsRef<str>>(version_string: S) -> bool {
let version_parts: Vec<&str> = version.split('.').collect();

// First, check if we have "10" as our first value
if !version_parts.first().is_some_and(|first| *first == "10") {
// FIXME: Once is_some_or is stabilized, replace the above with:
// if version_parts.first().is_none_or(|first| *first != "10") {
if version_parts.first().is_none_or(|first| *first != "10") {
return false;
}

Expand Down
Loading