refactor: use is_none_or for clippy::nonminimal_bool and resolve clippy::needless_raw_string_hashes
#231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayodejiige
previously approved these changes
Oct 21, 2024
NateD-MSFT
previously approved these changes
Oct 22, 2024
Signed-off-by: NateD-MSFT <[email protected]>
|
@wmmc88 Do you want to use this PR to fix the clippy::needless_raw_string_hashes issue as well just to clean everything up at once? |
NateD-MSFT
previously approved these changes
Oct 28, 2024
wmmc88
force-pushed
the
stable-is-some-or-nonminimal-bool
branch
from
519b939 to
de6177e
Compare
Fixed all the issues to unblock the pipeline |
wmmc88
changed the title
is_none_or for clippy::nonminimal_boolis_none_or for clippy::nonminimal_bool and resolve clippy::needless_raw_string_hashes
NateD-MSFT
approved these changes
Nov 6, 2024
ayodejiige
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small refactor in the version validation function to satisfy new clippy lint triggers (
clippy::nonminimal_bool,clippy::needless_raw_string_hashes), fixes to the winget installation action, and a minor formatting change in the wdk-sys build script. #230 silenced one instance ofclippy::nonminimal_boolin nightly builds, since the solution required the nightlyOption::is_none_orapi. This PR removes the silencing and fixes the core issue.Code Refactor:
is_none_ormethod, replacing the previous workaround. (crates/wdk-build/src/utils.rs)Winget Installation Script Update:
.github/actions/winget-install/action.yaml).github/actions/winget-install/action.yaml)Formatting Change:
clippy::needless_raw_string_hashes) inTEST_STUBS_TEMPLATEto improve code readability. (crates/wdk-sys/build.rs)This PR cannot merge until
Option::is_none_oris stabilized in rust 1.82.0 on 10/17/24.