Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register aten::pow.Scalar for aten::pow #1719

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

keenranger
Copy link
Contributor

@keenranger keenranger commented Jul 4, 2024

Hello,

After upgrading onnxscript from version 0.1.0.dev20240516 to the latest version, I encountered an error while trying to export my Torch model to ONNX:

torch.onnx._internal.diagnostics.infra.context.RuntimeErrorWithDiagnostic: Unsupported FX nodes: {'call_function': ['aten.pow.Scalar']}. 

Upon investigating the issue, I found that the changes made to aten_pow in PR #1612 are causing this problem. Reverting these changes allows the model to be exported to ONNX successfully again.

Could support for aten::pow be reintroduced to enable smooth exporting of models?

Thank you for your consideration.

Signed-off-by: Hankyeol Kyung <[email protected]>
@keenranger keenranger marked this pull request as ready for review July 4, 2024 09:09
@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.31%. Comparing base (08c8307) to head (619711d).

❗ There is a different number of reports uploaded between BASE (08c8307) and HEAD (619711d). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (08c8307) HEAD (619711d)
27 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1719       +/-   ##
===========================================
- Coverage   75.23%   40.31%   -34.93%     
===========================================
  Files         242      172       -70     
  Lines       25861    23385     -2476     
  Branches     4660     4205      -455     
===========================================
- Hits        19456     9427    -10029     
- Misses       5519    13557     +8038     
+ Partials      886      401      -485     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby changed the title Revert support for aten::pow Register aten::pow.Scalar for aten::pow Jul 4, 2024
Signed-off-by: Hankyeol Kyung <[email protected]>
@keenranger
Copy link
Contributor Author

Model still exportable with aten::pow.Scalar. Thank you @justinchuby !!
Formatting was needed, so I added commit about it.

@justinchuby justinchuby merged commit ee1ac58 into microsoft:main Jul 5, 2024
43 of 44 checks passed
@justinchuby
Copy link
Collaborator

Thank you for your contribution!

@keenranger keenranger deleted the revert-aten-pow branch July 6, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants