Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check for using -mavxvnni #21616

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix version check for using -mavxvnni #21616

merged 1 commit into from
Sep 12, 2024

Conversation

wangshuai09
Copy link
Contributor

Description

Change the CMAKE_CXX_COMPILER_VERSION greater than 11 for using '-mavxvnni'.

Motivation and Context

CMakeFiles/onnxruntime_mlas.dir/root/Git.d/onnxruntime/onnxruntime/core/mlas/lib/x86_64/QgemmU8S8KernelAvx2.S.o cc: error: unrecognized command-line option ‘-mavxvnni’; did you mean ‘-mavx512vnni’? using gcc (GCC) 10.3.1.

-mavxnni is supported since GCC 11 Release, this PR change the version check.

@wangshuai09
Copy link
Contributor Author

wangshuai09 commented Aug 13, 2024

Hi, @jywu-msft, i`ve found a error about -mavxvnni and fix this by updating version check. Can you help review this PR?

@jywu-msft jywu-msft requested review from snnn and yufenglee August 13, 2024 03:47
@wangshuai09
Copy link
Contributor Author

@snnn hi, there are still some CI pipeline need to run.

@wangshuai09
Copy link
Contributor Author

@snnn, this error cause the CI fault shown about Ascend NPU on Readme page.

@snnn
Copy link
Member

snnn commented Aug 28, 2024

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline

@snnn
Copy link
Member

snnn commented Aug 28, 2024

/azp run Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@snnn
Copy link
Member

snnn commented Aug 28, 2024

/azp run Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows GPU TensorRT CI Pipeline

@snnn
Copy link
Member

snnn commented Aug 28, 2024

/azp run Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@snnn snnn merged commit d539c27 into microsoft:main Sep 12, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants