Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux build (x64, WASM) of v1.19.2 fail #15

Closed
raphaelmenges opened this issue Sep 11, 2024 · 4 comments
Closed

Linux build (x64, WASM) of v1.19.2 fail #15

raphaelmenges opened this issue Sep 11, 2024 · 4 comments

Comments

@raphaelmenges
Copy link

raphaelmenges commented Sep 11, 2024

Hello 👋,

since the most recent version of ONNX runtime 1.19.2, the CI fails to build the Linux targets with x64 and WASM architecture. For example, the x64 build fails as follows:

[ 19%] Building ASM object onnxruntime/CMakeFiles/onnxruntime_mlas.dir/home/runner/work/onnxruntime-build/onnxruntime-build/onnxruntime/onnxruntime/core/mlas/lib/x86_64/QgemmU8S8KernelAvx2.S.o
cc: error: unrecognized command-line option ‘-mavxvnni’; did you mean ‘-mavx512vnni’?

I am confused what to do about it from "our" side. It looks like a problem within ONNX runtime? Perhaps we need a different GCC version or so?

Here is I believe the bespoken command-line option that causes the problem: https://github.com/microsoft/onnxruntime/blob/20d94648bbb106c74c43ef4023e142dee0342155/cmake/onnxruntime_mlas.cmake#L582

PS: I found this open pull request in the Microsoft repo: microsoft/onnxruntime#21616

raphaelmenges added a commit to raphaelmenges/onnxruntime-build that referenced this issue Sep 11, 2024
@raphaelmenges
Copy link
Author

I can confirm: CI works when GCC is newer or equal 11!

@snnn
Copy link

snnn commented Sep 12, 2024

WASM can support avx2? I thought it does not support any native assembly.

@raphaelmenges
Copy link
Author

I just saw that the WASM builds fail as well. I did not check why they failed so far!

Here you go: https://github.com/supertone-inc/onnxruntime-build/actions/runs/10764257894/job/29846819093#step:12:1250

@krazijames
Copy link
Collaborator

@raphaelmenges Thank you for the report. We can successfully build v1.19.2 now!

And according to the official documentation:

NOTE:

  • ONNX Runtime Web is dropping support for non-SIMD and non-threaded builds in future versions since v1.19.0.

So we also dropped those builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants